Messages in this thread Patch in this message |  | | Date | Fri, 16 Feb 2007 10:13:36 -0600 | From | Corey Minyard <> | Subject | Re: [patch 3/4] ipmi: add pci remove handling |
| |
On Fri, Feb 16, 2007 at 02:16:17PM +0100, Rolf Eike Beer wrote: > > Please use pci_{set,get}_drvdata() to access this field. > > Greetings, > > Eike
Yes, much better. Thanks. One more time...
Add pci_remove handling to the driver, so it will clean up if the device is hot-removed.
Signed-off-by: Corey Minyard <minyard@acm.org>
Index: linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c =================================================================== --- linux-2.6.20.orig/drivers/char/ipmi/ipmi_si_intf.c +++ linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c @@ -2191,12 +2191,15 @@ static int __devinit ipmi_pci_probe(stru info->irq_setup = std_irq_setup; info->dev = &pdev->dev; + pci_set_drvdata(pdev, info); return try_smi_init(info); } static void __devexit ipmi_pci_remove(struct pci_dev *pdev) { + struct smi_info *info = pci_get_drvdata(pdev); + cleanup_one_si(info); } #ifdef CONFIG_PM - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |