lkml.org 
[lkml]   [2007]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] libata updates (mostly fixes)
On Thu, Feb 15, 2007 at 03:48:04PM -0800, Linus Torvalds wrote:
>
>
> On Thu, 15 Feb 2007, Jeff Garzik wrote:
> >
> > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
> > index db185f3..d51f0f1 100644
> > --- a/arch/ia64/Kconfig
> > +++ b/arch/ia64/Kconfig
> > @@ -22,6 +22,7 @@ config IA64
> >
> > config 64BIT
> > bool
> > + select ATA_NONSTANDARD if ATA
> > default y
>
> Ok, this is just _strange_.
>
> Tying ATA_NONSTANDARD into ia64 by tying it to the 64BIT config variable
> may work (well, I _assume_ it does), but it's just psychedelic.
>
> How about adding a separate config entry like
>
> config IA64_ATA
> bool
> depends on ATA
> select ATA_NONSTANDARD
> default y
>
> which kind of makes sense when you squint just the right way..


What about simply providing asm/libata-portmap.h on all architectures
instead of this ATA_NONSTANDARD trickery?


> Linus

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-16 13:05    [from the cache]
©2003-2011 Jasper Spaans