lkml.org 
[lkml]   [2007]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] libata updates (mostly fixes)
Jeff Garzik wrote:
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -352,7 +352,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
> {
> if (ata_id_major_version(dev_id) >= 5 && ata_id_is_sata(dev_id))
> return 0; /* SATA */
> - if (dev_id[93] & 0x4000)
> + if ((dev_id[93] & 0xE000) == 0x6000)
> return 0; /* 80 wire */
> return 1;
> }

A thought: it seems to me that the major version check should be moved
into ata_id_is_sata().

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-16 00:47    [W:0.405 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site