Messages in this thread | | | Date | Thu, 15 Feb 2007 11:14:58 -0800 (PST) | From | Davide Libenzi <> | Subject | Re: [patch 08/14] syslets: x86, add create_async_thread() method |
| |
On Thu, 15 Feb 2007, Ingo Molnar wrote:
> +ENTRY(async_thread_helper) > + CFI_STARTPROC > + /* > + * Allocate space on the stack for pt-regs. > + * sizeof(struct pt_regs) == 64, and we've got 8 bytes on the > + * kernel stack already: > + */ > + subl $64-8, %esp > + CFI_ADJUST_CFA_OFFSET 64
Maybe a comment here would help in explaining why we do need space for the extra pt_regs (on top of the one already allocated in do_fork()) ;) It's not immediately clear that ret_from_fork and syscall_exit will issue two nested RESTORE_REGS.
- Davide
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |