lkml.org 
[lkml]   [2007]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] aio: fix kernel bug when page is temporally busy
    Date
    > If invalidate_inode_pages2_range() will return EIOCBRETRY as the patch
    > "aio: fix kernel bug when page is temporally busy"

    Sorry Leonid, this patch is not safe.

    It returns -EIOCBRETRY without guaranteeing that kick_iocb() will be
    called. This can lead to operations hanging, both AIO and calls that
    come through do_sync_{read,write}.

    It overwrites -EIOCBQUEUED, leading to an aio_complete() while a
    retry is happening. This can lead to reference count confusion.
    Double-frees, referencing freed memory, that kind of thing. This
    isn't a new problem. The current code that overwrites with -EIO has
    this problem. But moving to -EIOCBRETRY does introduce new behaviour
    of aio_complete() and the retry path racing.

    I'll have a candidate patch to address the problem of EIO being
    raised on the way back up from a path which has returned -EIOCBQUEUED.

    - z
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-15 19:29    [W:0.043 / U:30.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site