Messages in this thread | | | Subject | Re: [patch 10/21] Xen-paravirt: Name: dont export paravirt_ops structure, do individual functions | From | Rusty Russell <> | Date | Wed, 14 Feb 2007 16:51:20 +1100 |
| |
On Tue, 2007-02-13 at 17:06 -0800, Zachary Amsden wrote: > Jeremy Fitzhardinge wrote: > > Wrap the paravirt_ops members we want to export in wrapper functions. > > Since we binary-patch the critical ones, this doesn't make a speed > > impact. > > This turned out really hideous looking to me. Can't we split the struct > into GPL'd and non-GPL'd functions instead? We still have the same > granularity, and none of this function call to an indirect function call > nonsense.
This patch, indeed, should not have been pushed in this series. But not for that reason: I actually prefer explicit exports.
KVM and lguest need more symbols, so the real patch will make them use native_XXX versions explicitly...
Cheers, Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |