lkml.org 
[lkml]   [2007]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [GIT] NFS client updates for 2.6.20
From
Date
On Mon, 2007-02-12 at 23:39 -0800, Trond Myklebust wrote:

> commit 7c85d9007d05436e71d2b805b96c1e36a8193bd4
> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Wed Dec 13 15:23:48 2006 -0500
>
> NFS: Fixup some outdated comments...
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

A few new comments would be appreciated :-)

> commit 02241bc47e8961768de83d855accd0dcad1df045
> Author: Trond Myklebust <Trond.Myklebust@netapp.com>
> Date: Sat Jan 13 02:28:07 2007 -0500
>
> NFS: Ensure that ->writepage() uses flush_stable() when reclaiming pages
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

That patch seems to make all ->writepage() calls use stable storage.
Of course, given that there are no other ->writepage() calls this
works out.

I've been using this:
---

Subject: nfs: only use stable storage for swap

unstable writes don't make sense for swap pages.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
---
fs/nfs/write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-git/fs/nfs/write.c
===================================================================
--- linux-2.6-git.orig/fs/nfs/write.c 2007-01-09 11:38:25.000000000 +0100
+++ linux-2.6-git/fs/nfs/write.c 2007-01-09 13:40:34.000000000 +0100
@@ -231,7 +231,7 @@ static int nfs_writepage_setup(struct nf
static int wb_priority(struct writeback_control *wbc)
{
if (wbc->for_reclaim)
- return FLUSH_HIGHPRI;
+ return FLUSH_HIGHPRI|FLUSH_STABLE;
if (wbc->for_kupdate)
return FLUSH_LOWPRI;
return 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-13 11:47    [W:0.071 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site