lkml.org 
[lkml]   [2007]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch] net, 8139too.c: fix netpoll deadlock
From
Let me resume two months old topic...

On Wed, 13 Dec 2006 02:12:31 +0100, Ingo Molnar <mingo@elte.hu> wrote:
> > I have lived with the "NAPI ->poll() handler runs in BH irq enabled
> > context" rule for years. Is it definitely false/dead ?
> >
> > If so at least 8139cp needs the same fix.
>
> hm, this isnt really about NAPI polling, but about the
> netconsole/netpoll/netdump poll_controller() handler.
>
> with netconsole, printk can be called from IRQ context (and is
> frequently from IRQ context during bootup or module initialization), so
> a BH rule isnt enough for them.

I see NAPI poll routine might be called with interrupt disabled.

Many (all?) NAPI drivers call netif_receive_skb() from its poll
routine (as described in NAPI-HOWTO.txt), but I thought
netif_receive_skb() cannot be called from irq context or irq disabled.
So it seems the problem is not solved completely. Or am I missing
something?

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-14 03:35    [W:0.087 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site