Messages in this thread |  | | Date | Tue, 13 Feb 2007 10:11:15 -0800 | From | "Martin J. Bligh" <> | Subject | Re: [RFC] [PATCH] more support for memory-less-node. |
| |
Andi Kleen wrote: >> Your description of the node is correct, it's an arbitrary container of >> one or more resources. Not only is this definition flexible, it's also >> very useful, for memory hotplug, odd types of NUMA boxes, etc. > > I must disagree here. Special cases are always dangerous especially > if they are hard to regression test. I made this discovery the hard > way on x86-64 ... It's best to eliminate them in the first place, > otherwise they will later come back and bite you when you don't expect it. > > Adding NULL tests all over mm for this would seem like a clear case > of this to me.
I wasn't suggesting having NULL pointers for pgdats, if that's what you mean. Just nodes with no memory in them, the pgdat would still be there. pgdat = struct node, except everything's badly named.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |