lkml.org 
[lkml]   [2007]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH x86 for review II] [20/39] i386: Small cleanup to TLB flush code
    Date

    - Remove outdated comment
    - Use cpu_relax() in a busy loop

    Signed-off-by: Andi Kleen <ak@suse.de>

    ---
    arch/i386/kernel/smp.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    Index: linux/arch/i386/kernel/smp.c
    ===================================================================
    --- linux.orig/arch/i386/kernel/smp.c
    +++ linux/arch/i386/kernel/smp.c
    @@ -375,8 +375,7 @@ static void flush_tlb_others(cpumask_t c
    /*
    * i'm not happy about this global shared spinlock in the
    * MM hot path, but we'll see how contended it is.
    - * Temporarily this turns IRQs off, so that lockups are
    - * detected by the NMI watchdog.
    + * AK: x86-64 has a faster method that could be ported.
    */
    spin_lock(&tlbstate_lock);

    @@ -401,7 +400,7 @@ static void flush_tlb_others(cpumask_t c

    while (!cpus_empty(flush_cpumask))
    /* nothing. lockup detection does not belong here */
    - mb();
    + cpu_relax();

    flush_mm = NULL;
    flush_va = 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-02-12 08:49    [W:0.031 / U:30.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site