Messages in this thread |  | | Date | Tue, 13 Feb 2007 01:32:58 +0100 | Subject | Re: [patch 3/3, resend] kbuild: correctly skip tilded backups in localversion files | From | Oleg Verych <> |
| |
On Mon, Feb 12, 2007 at 02:53:29PM -0800, Linus Torvalds wrote:
Hallo.
> On Mon, 12 Feb 2007, Tony Luck wrote: > > > > Git bisect fingers this patch (which is in Linus' tree as commit > > 76c329563c5b8663ef27eb1bd195885ab826cbd0) as the culprit > > for double adding the contents of the localversion file. E.g. > > > > $ echo -tiger-smp > localversion > > $ make prepare > > $ make kernelrelease > > 2.6.20-tiger-smp-tiger-smp > > Heh. It's because we search for the localversion files in both $objtree > and $srctree, and normally they are one and the same - so it finds the > same file twice. > > The old code did the same thing, but with the "make" $(sort ..) function, > which apparently removes duplicates. We should use "sort -u" here.
Heh. Why one ever going to bloat $(srctree) to add more "dontdiff" and such, where build is supporting dirty output?
While this is my mis-tesing,
> Both the old code *and* the new code is just horribly complex. The old > code appears to suffer from GNU $(wildcard ..), the new code is almost as > ugly in doing an unnecessarily complex "find".
any reasons to have multiple files for localversion(s), in $(objtree) also? Exept one, that somebody used to use it, mm-tree doesn't btw.
As i opposed to Romans's "make" solution, because it wasn't obvious, i agree current has heavy `find', but what else you can propose? I think, it's not make's job after all.
> Oh well.
Thanks for testing! ____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |