lkml.org 
[lkml]   [2007]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/isdn/gigaset: new M101 driver
    Am 12.02.2007 19:47 schrieb Greg KH:

    >>>>> +static void gigaset_device_release(struct device *dev)
    >>>>> +{
    >>>>> + //FIXME anything to do? cf. platform_device_release()
    >>>>> +}

    > The memory of the platform device itself needs to be freed here,
    > otherwise, to do it earlier would cause race conditions and oopses.

    I don't do it earlier. I do it later. My platform_device structure
    is part of my driver's device state structure which is freed
    explicitly later after the call to platform_device_unregister().
    Is that bad?

    > Look at how the other platform drivers do things.

    They do things differently from each other as well as from mine.
    block/floppy.c, for example, just has a call to complete() there.

    Anyway, in the latest version of my driver, its platform_device
    release function finally does something, too: it frees
    dev->platform_data and pdev->resource just in case something
    might have materialized there. I hope that's ok.

    Regards,
    Tilman

    --
    Tilman Schmidt E-Mail: tilman@imap.cc
    Bonn, Germany
    Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
    Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-02-13 00:53    [W:2.643 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site