lkml.org 
[lkml]   [2007]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: NAK new drivers without proper power management?
    Hi!

    > > > > > Neither am I. I'm just asking that new drivers have power management as
    > > > > > standard.
    > > >
    > > > > What if the hardware doesn't support power management ?
    > > >
    > > > You would still want to do the cleanup and configuration that you'd do
    > > > for module load/unload.
    > > >
    > > By adding dummy functions, wouldn't that just look awkward ?
    >
    > If all you need to do is say 'I don't need to do anything' and we have a
    > shared function that does that, all we're talking about doing is adding
    > to your struct pci_device (or whatever)
    >
    > .resume = generic_empty_resume;
    >
    > To me at least, that doesn't look awkward, and says cleanly and clearly
    > that you've checked things over and decided you know what's required.

    Actually, I'd like it to be

    .resume = generic_empty_resume; /* Explain, why your driver needs no
    resume */

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-12 17:57    [W:4.147 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site