lkml.org 
[lkml]   [2007]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch] linux/io.h: forward declare struct pci_dev
    On Sat, Feb 10, 2007 at 12:45:50PM +0100, Heiko Carstens wrote:
    > From: Heiko Carstens <heiko.carstens@de.ibm.com>
    >
    > 9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this:
    >
    > CC arch/s390/mm/ioremap.o
    > In file included from arch/s390/mm/ioremap.c:18:
    > include/linux/io.h:46:
    > warning: "struct pci_dev" declared inside parameter list
    > include/linux/io.h:46:
    > warning: its scope is only this definition or declaration,
    > which is probably not what you want
    >
    > Guess it's time to get rid of ioremap.c on s390 if possible...
    >
    > Cc: Tejun Heo <htejun@gmail.com>
    > Cc: Jeff Garzik <jeff@garzik.org>
    > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    > ---
    > include/linux/io.h | 1 +
    > 1 files changed, 1 insertion(+)
    >
    > Index: linux-2.6/include/linux/io.h
    > ===================================================================
    > --- linux-2.6.orig/include/linux/io.h
    > +++ linux-2.6/include/linux/io.h
    > @@ -22,6 +22,7 @@
    > #include <asm/io.h>
    > #include <asm/page.h>
    >
    > +struct pci_dev;
    > struct device;

    I haven't looked at what causes it, but any leakage of pci details
    into io.h is bogus. I'd suggest that the original submitter fixes
    up that problem instead.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-11 04:55    [W:0.030 / U:29.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site