lkml.org 
[lkml]   [2007]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: NAK new drivers without proper power management?
Am 10.02.2007 07:43 schrieb Willy Tarreau:
> On Fri, Feb 09, 2007 at 07:25:34PM -0500, Jeff Garzik wrote:

>>>> On Sat, 2007-02-10 at 08:57 +1100, Nigel Cunningham wrote:
>>>>> Can we start to NAK new drivers that don't have proper power management
>>>>> implemented?
[...]
>> Certainly we should ask for it, but it shouldn't be a merge-stopper.
>
> I think we should even proceed in the opposite direction : refuse to suspend
> if at least one driver does not support the feature, and enumerate the
> faulty drivers on the console. While I agree that a machine which resumes
> in a bad state is not funny at all to debug, at least when the user expects
> his notebook to suspend and sees that it refuses, he can complain about the
> drivers which do not support it, and can even unload them first if unneeded.

I agree wholeheartedly. That's the correct way to handle this.

--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
- In theory, there is no difference between theory and practice.
In practice, there is.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-02-11 00:53    [W:0.097 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site