lkml.org 
[lkml]   [2007]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PS3: trouble with SPARSEMEM_VMEMMAP and kexec
Geert Uytterhoeven wrote:
> On Wed, 5 Dec 2007, Geoff Levand wrote:
>> Andrew Morton wrote:
>> > On Wed, 5 Dec 2007 10:52:48 +0100 (CET)
>> > Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote:
>> >
>> >> --------------------------------------------------------------------------------
>> >> Subject: sparsemem: sparse_add_one_section() may fail to allocate memory
>> >>
>> >> sparsemem: sparse_add_one_section() may fail to allocate memory, and must check
>> >> whether the allocation succeeded before proceeding to touch the allocated
>> >> memory.
>> >>
>> >> From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
>> >>
>> >> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
>> >> ---
>> >> FIXME There are still some possible memory leaks in sparse_add_one_section():
>> >> - usemap is never deallocated
>> >> - __kfree_section_memmap() is a not yet implemented dummy
>> >
>> > I already had
>> >
>> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-improve-the-error-handling-for-sparse_add_one_section.patch
>> > and
>> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-check-the-return-value-of-sparse_index_alloc.patch
>> >
>> > queued. Do they fix the problem, and should they be merged in 2.6.24?
>>
>> No, a quick test shows it just panics in a different place. Geert's
>> patch does also.
>
> What do you mean, that it still paniced after my patch?
>
> The kernel did boot succesfully for me when passing ps3fb=48M. Userspace saw 58
> MiB (128 MiB - kernelsize - 48 MiB(ps3fb)).
>
> I did not try kexec, though.

On looking at it, your patch should have worked, so I guess I didn't boot the
correct image, or something like that. Sorry.

-Geoff



\
 
 \ /
  Last update: 2007-12-07 06:57    [W:0.088 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site