lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [REPOST PATCH] Add iSCSI IBFT support (v0.4)
Date
From
[added cc: to mikec]

On Wed, 05 Dec 2007 16:40:46 -0400, Konrad Rzeszutek wrote:
> On Wed, Dec 05, 2007 at 02:26:40PM -0600, Doug Maxey wrote:
> >
> > On Wed, 05 Dec 2007 13:41:21 -0400, Konrad Rzeszutek wrote:
> > > > Is the current include from open-iscsi being duplicated? If not, why
> > > > not consolidate in one file?
> > >
> > > The include files that come from open-iscsi that are in the kernel do
> > > not have the iBFT data structures in them - therefore no duplication.
> >
> > That is strictly true, at least the "in the kernel" part. There is a
> > file with the definitions, open-iscsi utils/fwparam_ibft/fwparam_ibft.h
> > does have the previous definitons. So what to do? Drop that one? Or
> > keep duplicating?
>
> I would say that utils/fwparam_ibft/fwparam_ibft.h and
> utils/fwparam_ibft/fwparam_ibft.c would be dropped once this kernel
> patch and the patch to open-iscsi to add fwparam_ibft_subsys.c are
> reviewed and hopefully accepted.
>

Ok. If indeed the userspace tool is going completely away, then there
would be just the single instance. Is that the plan?




\
 
 \ /
  Last update: 2007-12-05 22:07    [W:0.258 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site