lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86_64: some whitespace cleanups in paging code
    On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
    > This patch does some whitespace cleanups in the paging code to fix some
    > checkpatch.pl warnings of my formerly merged cleanup patches.
    >...
    > - set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
    > + set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));

    Did checkpatch enforce you to remove the spaces around '+'? I thought
    there was/is a common consensus that having spaces around operators is a good
    thing to have. IMHO it's much more readable...
    But anyway, it's not that I want to start a new thread about coding style :)


    \
     
     \ /
      Last update: 2007-12-05 17:39    [W:2.731 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site