lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86_64: some whitespace cleanups in paging code

    * Joerg Roedel <joerg.roedel@amd.com> wrote:

    > This patch does some whitespace cleanups in the paging code to fix
    > some checkpatch.pl warnings of my formerly merged cleanup patches.

    thanks, applied.

    btw., if there's any file you are particularly interested in cleaning up
    as a whole, you can use the --file option:

    scripts/checkpatch.pl --file include/asm-x86/pgtable_64.h

    there's no hard policy on whether cleanups should be done
    pre-unification or post-unification. I've been using the following
    pretty sensible 3-step path when doing manual unifications:

    - clean up the _32 and _64 file first (this is also easy to check - the
    resulting .o or vmlinux must not differ with/without the patch)

    - remove artificial differences (in a separate patch)

    - do the unification (in a third patch)

    the general rule, more patches are better than fewer patches. Most of
    our testing/bisetion infrastructure is per-patch/per-commit, so if some
    mistake happens (and mistakes happen all the time), the finer grained
    approach is always easier to sort out.

    Ingo


    \
     
     \ /
      Last update: 2007-12-05 15:55    [W:3.913 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site