lkml.org 
[lkml]   [2007]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7][QUOTA] Move sysctl management code under ifdef CONFIG_SYSCTL
[snip]

>> We do have some current code in the network stack that fails miserably
>> when register_sysctl_table returns NULL, and there are explicit
>> checks for that.
>
> So that code would be failing today with CONFIG_SYSCTL=n? Unless the
> failing code is itself under #ifdef CONFIG_SYSCTL, in which case we don't
> need to change anything?

Exactly! If the code checks for the return value it won't work
with CONFIG_SYSCTL=n, if it dies not - it may happily use the
sysctl stub and avoid extra ifdefs.

But this difference looks clumsy :(

Thanks,
Pavel


\
 
 \ /
  Last update: 2007-12-04 13:01    [W:0.179 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site