Messages in this thread | | | Date | Tue, 4 Dec 2007 19:09:23 -0800 | From | Andrew Morton <> | Subject | Re: [-mm PATCH] kallsyms should prefer non weak symbols |
| |
On Tue, 04 Dec 2007 20:35:32 +0000 Paulo Marques <pmarques@grupopie.com> wrote:
> When resolving symbol names from addresses with aliased symbol names, > kallsyms_lookup always returns the first symbol, even if it is a weak > symbol. > > This patch changes this by sorting the symbols with the weak symbols > last before feeding them to the kernel. This way the kernel runtime > isn't changed at all, only the kallsyms build system is changed. > > Another side effect is that the symbols get sorted by address, too. So, > even if future binutils version have some bug in "nm" that makes it fail > to correctly sort symbols by address, the kernel won't be affected by this. > > > From: Paulo Marques <pmarques@grupopie.com> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
The signoffs don't make sense.
If you authored the patch then please put a From: at the top of the changelog and include your signed-off-by:.
If Mathieu worked on or forwarded the patch then include his s-o-b. If he wasn't in the delivery path but has tested/reviewed/approved the patch then Acked-by: is more appropriate. Documentation/SubmittingPatches has details...
| |