lkml.org 
[lkml]   [2007]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] x86: Unify include/asm-x86/linkage_[32|64].h

* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> I'm not sure if the definition of asmlinkage and prevent_tail_call can
> be omitted as well and let the linux/linkage.h version get picked up
> instead.

no, we cannot remove them - asmlinkage is needed for the syscall entry
(and other entry code) to work, the and the prevent_tail_call works
around a compiler bug. (which might or might not be fixed in latest gcc
- but we generally dont remove workarounds unless we are really sure
it's fine.)

so your patch looks good to me, i've queued it up.

Ingo


\
 
 \ /
  Last update: 2007-12-04 22:35    [W:0.090 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site