Messages in this thread | | | Date | Tue, 4 Dec 2007 11:39:54 -0800 | From | Andrew Morton <> | Subject | Re: [patch 1/2] Linux Kernel Markers - Support Multiple Probes |
| |
On Tue, 4 Dec 2007 14:21:00 -0500 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> > > + */ > > > +void marker_probe_cb(const struct marker *mdata, void *call_private, > > > + const char *fmt, ...) > > > +{ > > > + va_list args; > > > + char ptype; > > > + > > > + preempt_disable(); > > > > What are the preempt_disable()s doing in here? > > > > Unless I missed something obvious, a comment is needed here (at least). > > > > They make sure the teardown of the callbacks can be done correctly when > they are in modules and they insure RCU read coherency. Will add > comment.
So shouldn't it be using rcu_read_lock()? If that does not suit, should we be adding new rcu primitives rather than open-coding and adding dependencies?
| |