Messages in this thread | | | Date | Tue, 04 Dec 2007 14:02:34 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] sata_nv: don't use legacy DMA in ADMA mode (v3) |
| |
Robert Hancock wrote: > We need to run any DMA command with result taskfile requested in ADMA mode > when the port is in ADMA mode, otherwise it may try to use the legacy DMA engine > in ADMA mode which is not allowed. Enforce this with BUG_ON() since data > corruption could potentially result if this happened. Also, fail any attempt to > try and issue NCQ commands with result taskfile requested, since the hardware > doesn't allow this. > > Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied #upstream-fixes
Please make sure to copy relevant NVIDIA engineers on your patches, since they are actively contributing patches to Linux too (and, well, its their hardware :))
Jeff
| |