lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 35/52] KVM: x86 emulator: retire ->write_std()
    Date
    Theoretically used to acccess memory known to be ordinary RAM, it was
    never implemented. It is questionable whether it is possible to implement
    it correctly.

    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/x86.c | 10 ----------
    drivers/kvm/x86_emulate.h | 11 -----------
    2 files changed, 0 insertions(+), 21 deletions(-)

    diff --git a/drivers/kvm/x86.c b/drivers/kvm/x86.c
    index 6212984..5a54e32 100644
    --- a/drivers/kvm/x86.c
    +++ b/drivers/kvm/x86.c
    @@ -1162,15 +1162,6 @@ int emulator_read_std(unsigned long addr,
    }
    EXPORT_SYMBOL_GPL(emulator_read_std);

    -static int emulator_write_std(unsigned long addr,
    - const void *val,
    - unsigned int bytes,
    - struct kvm_vcpu *vcpu)
    -{
    - pr_unimpl(vcpu, "emulator_write_std: addr %lx n %d\n", addr, bytes);
    - return X86EMUL_UNHANDLEABLE;
    -}
    -
    static int emulator_read_emulated(unsigned long addr,
    void *val,
    unsigned int bytes,
    @@ -1367,7 +1358,6 @@ EXPORT_SYMBOL_GPL(kvm_report_emulation_failure);

    struct x86_emulate_ops emulate_ops = {
    .read_std = emulator_read_std,
    - .write_std = emulator_write_std,
    .read_emulated = emulator_read_emulated,
    .write_emulated = emulator_write_emulated,
    .cmpxchg_emulated = emulator_cmpxchg_emulated,
    diff --git a/drivers/kvm/x86_emulate.h b/drivers/kvm/x86_emulate.h
    index e34868b..a62bf14 100644
    --- a/drivers/kvm/x86_emulate.h
    +++ b/drivers/kvm/x86_emulate.h
    @@ -63,17 +63,6 @@ struct x86_emulate_ops {
    unsigned int bytes, struct kvm_vcpu *vcpu);

    /*
    - * write_std: Write bytes of standard (non-emulated/special) memory.
    - * Used for stack operations, and others.
    - * @addr: [IN ] Linear address to which to write.
    - * @val: [IN ] Value to write to memory (low-order bytes used as
    - * required).
    - * @bytes: [IN ] Number of bytes to write to memory.
    - */
    - int (*write_std)(unsigned long addr, const void *val,
    - unsigned int bytes, struct kvm_vcpu *vcpu);
    -
    - /*
    * read_emulated: Read bytes from emulated/special memory area.
    * @addr: [IN ] Linear address from which to read.
    * @val: [OUT] Value read from memory, zero-extended to 'u_long'.
    --
    1.5.3.7


    \
     
     \ /
      Last update: 2007-12-30 08:25    [W:0.021 / U:1.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site