lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 33/52] KVM: MMU: Fix potential memory leak with smp real-mode
    Date
    From: Izik Eidus <izike@qumranet.com>

    When we map a page, we check whether some other vcpu mapped it for us and if
    so, bail out. But we should decrease the refcount on the page as we do so.

    Signed-off-by: Izik Eidus <izike@qumranet.com>
    Signed-off-by: Avi Kivity <avi@qumranet.com>
    ---
    drivers/kvm/mmu.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
    index 87d8e70..8add4d5 100644
    --- a/drivers/kvm/mmu.c
    +++ b/drivers/kvm/mmu.c
    @@ -907,8 +907,10 @@ static int nonpaging_map(struct kvm_vcpu *vcpu, gva_t v, hpa_t p)

    pte = table[index];
    was_rmapped = is_rmap_pte(pte);
    - if (is_shadow_present_pte(pte) && is_writeble_pte(pte))
    + if (is_shadow_present_pte(pte) && is_writeble_pte(pte)) {
    + kvm_release_page(pfn_to_page(p >> PAGE_SHIFT));
    return 0;
    + }
    mark_page_dirty(vcpu->kvm, v >> PAGE_SHIFT);
    page_header_update_slot(vcpu->kvm, table, v);
    table[index] = p | PT_PRESENT_MASK | PT_WRITABLE_MASK |
    --
    1.5.3.7


    \
     
     \ /
      Last update: 2007-12-30 08:23    [W:4.115 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site