Messages in this thread Patch in this message | | | Date | Sun, 30 Dec 2007 23:02:06 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override |
| |
* Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > ok. Like the patch below? > > Not quite - you still need the loop in case you NMI and then run off > into oblivion
yes indeed. Updated patch below.
Ingo
--------------> Subject: x86: hlt on early crash From: Ingo Molnar <mingo@elte.hu>
H. Peter Anvin <hpa@zytor.com> wrote:
> It probably should actually HLT, to avoid sucking power, and stressing > the thermal system. We're dead at this point, and the early 486's > which had problems with HLT will lock up - we don't care.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/boot/compressed/misc_32.c | 3 ++- arch/x86/boot/compressed/misc_64.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
Index: linux-x86.q/arch/x86/boot/compressed/misc_32.c =================================================================== --- linux-x86.q.orig/arch/x86/boot/compressed/misc_32.c +++ linux-x86.q/arch/x86/boot/compressed/misc_32.c @@ -339,7 +339,8 @@ static void error(char *x) putstr(x); putstr("\n\n -- System halted"); - while(1); /* Halt */ + while (1) + asm("hlt"); } asmlinkage void decompress_kernel(void *rmode, unsigned long end, Index: linux-x86.q/arch/x86/boot/compressed/misc_64.c =================================================================== --- linux-x86.q.orig/arch/x86/boot/compressed/misc_64.c +++ linux-x86.q/arch/x86/boot/compressed/misc_64.c @@ -338,7 +338,8 @@ static void error(char *x) putstr(x); putstr("\n\n -- System halted"); - while(1); /* Halt */ + while (1) + asm("hlt"); } asmlinkage void decompress_kernel(void *rmode, unsigned long heap,
| |