Messages in this thread |  | | Date | Sun, 30 Dec 2007 22:32:12 +0100 (CET) | | From | Bodo Eggert <> | | Subject | Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override |
| |
On Sun, 30 Dec 2007, Ingo Molnar wrote: > * H. Peter Anvin <hpa@zytor.com> wrote: > > Ingo Molnar wrote: > >> * Bodo Eggert <7eggert@gmx.de> wrote:
> >>> BTW: The error function in linux-2.6.23/arch/i386/boot/compressed/misc.c > >>> uses while(1) without cpu_relax() in order to halt the machine. Is this > >>> fixed? Should it be fixed? > >> > >> this is early bootup so there's no need to be "nice" to other cores or > >> sockets - none of them are really running. > >> > > > > It probably should actually HLT, to avoid sucking power, and stressing > > the thermal system. We're dead at this point, and the early 486's > > which had problems with HLT will lock up - we don't care. > > ok. Like the patch below?
> > - while(1); /* Halt */ > + asm("cli; hlt"); /* Halt */
The other users would loop around the hlt. Cargo Cult? -- Top 100 things you don't want the sysadmin to say: 97. Go get your backup tape. (You _do_ have a backup tape?)
|  |