lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [x86] is checkpatch.pl broken
    [Ingo Molnar - Sun, Dec 30, 2007 at 06:22:50PM +0100]
    |
    | * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
    |
    | > orig:
    | > mbr_base = (buf_base+sector_size-1) & ~(sector_size-1);
    | > new (could be):
    | > mbr_base = (buf_base + sector_size - 1) & ~(sector_size - 1);
    | >
    | > Is a new version that bad?
    |
    | it's certainly acceptable as newly introduced code but only borderline
    | better than the original code. I'd suggest to stick to the problem areas
    | that checkpatch.pl complains about at the moment - we have really
    | obvious bad looking pieces of code that checkpatch.pl reports, and going
    | after the borderline cases will only result in coding-style lawyering
    | and flamewars, not any genuine increase in code quality ;-)
    |
    | for example:
    |
    | arch/x86/kernel/bootflag.c:
    |
    | total: 19 errors, 2 warnings, 98 lines checked
    |
    | or:
    |
    | arch/x86/kernel/apm_32.c:
    |
    | total: 56 errors, 31 warnings, 2402 lines checked
    |
    | and once we have nothing but the borderline cases and if we get really
    | bored we can start coding style flamewars ;-)
    |
    | Ingo
    |

    Thanks Ingo, you're quite right! Next time i'll appear in list with real
    (and hope usefull) patch ;)

    Cyrill



    \
     
     \ /
      Last update: 2007-12-30 19:29    [W:0.026 / U:0.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site