lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag
Date
On Saturday 29 December 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > * Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap.
>
> > * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers.
>
> > * Convert ide-tape device driver to check for IDE_HFLAG_NO_DSC flag.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> > Index: b/include/linux/ide.h
> > ===================================================================
> > --- a/include/linux/ide.h
> > +++ b/include/linux/ide.h
> > @@ -1098,6 +1098,8 @@ enum {
> > IDE_HFLAG_CY82C693 = (1 << 27),
> > /* force host out of "simplex" mode */
> > IDE_HFLAG_CLEAR_SIMPLEX = (1 << 28),
> > + /* DSC overlap is unsupported */
> > + IDE_HFLAG_NO_DSC = (1 << 29),
> > };
>
> Too many flags -- you'll run out of sizeof(unsigned) soon. :-)

Actually I'm already one bit short for WIP patches.... :)

I can compensate for it by using the same bit for IDE_HFLAG_CS5520
and IDE_HFLAG_VDMA for now (they are set only by cs5520 host driver)
but long-term we should get rid of some flags (IDE_HFLAG_ABUSE*,
especially IDE_HFLAG_ABUSE_DMA_MODES, sound like a good candidates
for extermination) or make flags field u64 (eeew)...

Bart


\
 
 \ /
  Last update: 2007-12-30 18:35    [W:0.041 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site