lkml.org 
[lkml]   [2007]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: Regression - 2.6.24-rc3 - umem nvram card driver oops
    On Tuesday December 4, dgc@sgi.com wrote:
    > Neil,
    >
    > I just upgraded an ia64 (Altix, 16k page size) test box to 2.6.24-rc3
    > from 2.6.23 and I get it panicing on boot in the umem driver.

    Cool - someone is using umem! And even testing it. Thanks!

    A quick look shows a probable NULL deref. Let me know if this fixes
    it. I'll read through the offending patch more carefully and make
    sure there is nothing else wrong.

    NeilBrown


    Fix possible NULL dereference in umem.c

    Signed-off-by: Neil Brown <neilb@suse.de>

    ### Diffstat output
    ./drivers/block/umem.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff .prev/drivers/block/umem.c ./drivers/block/umem.c
    --- .prev/drivers/block/umem.c 2007-12-04 11:11:30.000000000 +1100
    +++ ./drivers/block/umem.c 2007-12-04 11:11:42.000000000 +1100
    @@ -484,7 +484,8 @@ static void process_page(unsigned long d
    page->idx++;
    if (page->idx >= bio->bi_vcnt) {
    page->bio = bio->bi_next;
    - page->idx = page->bio->bi_idx;
    + if (page->bio)
    + page->idx = page->bio->bi_idx;
    }

    pci_unmap_page(card->dev, desc->data_dma_handle,



    \
     
     \ /
      Last update: 2007-12-04 01:17    [W:0.021 / U:28.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site