Messages in this thread | | | Date | Mon, 03 Dec 2007 17:55:44 -0500 (EST) | Subject | Re: [PATCH 09/28] blk_end_request: changing ps3disk (take 3) | From | Kiyoshi Ueda <> |
| |
Hi Geert,
On Sun, 2 Dec 2007 10:34:56 +0100 (CET), Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> wrote: > On Fri, 30 Nov 2007, Kiyoshi Ueda wrote: > > This patch converts ps3disk to use blk_end_request(). > ^^^^^^^^^^^^^^^ > Patch subject and description are inconsistent with actual change. > > > Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> > > Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> > > --- > > drivers/block/ps3disk.c | 6 +----- > > 1 files changed, 1 insertion(+), 5 deletions(-) > > > > Index: 2.6.24-rc3-mm2/drivers/block/ps3disk.c > > =================================================================== > > --- 2.6.24-rc3-mm2.orig/drivers/block/ps3disk.c > > +++ 2.6.24-rc3-mm2/drivers/block/ps3disk.c > > @@ -280,11 +280,7 @@ static irqreturn_t ps3disk_interrupt(int > > } > > > > spin_lock(&priv->lock); > > - if (!end_that_request_first(req, uptodate, num_sectors)) { > > - add_disk_randomness(req->rq_disk); > > - blkdev_dequeue_request(req); > > - end_that_request_last(req, uptodate); > > - } > > + __blk_end_request(req, uptodate, num_sectors << 9); > ^^^^^^^^^^^^^^^^^
Thank you for the comment. The description meant the blk_end_request family, not actual function, blk_end_request(). But as you pointed out, it is misleading. I'll change the description of all related patches.
Thanks, Kiyoshi Ueda
| |