Messages in this thread | | | Date | Sat, 29 Dec 2007 20:03:09 +0100 | From | Sam Ravnborg <> | Subject | Re: [patch 2.6.24-rc6-mm 1/9] gpiolib: add drivers/gpio directory |
| |
On Sat, Dec 29, 2007 at 10:19:39AM -0800, David Brownell wrote: > On Friday 28 December 2007, Sam Ravnborg wrote: > > kconfig symbols that are "select" targets should be named "HAVE_" so in > > this case you could use HAVE_GPIO_LIB. > > This is by convention only but introduced to make it visible that this is > > a config symbol supposed to be selected. > > Not widely adopted yet, but of course such things take time.
Yes - which is why I am a bit more careful to note it. > > > > Then on top of that the HAVE_ symbols should not have any dependencies > > so we avoid that "select" selects a symbol where the dependencies are > > not fulfilled. > > That limitation of "select" still seems more buglike to me than > anything else, FWIW. Not that it matters in this case. But I had not yet figured out how to fix it - and limiting select to symbols without dependencies avoid the worst offendes/abusers.
> Pretty much like the folowing, then? > > - Use "ccflags-$(CONGIF_DEBUG_GPIO) += -DDEBUG" instead of > those ugly (but traditional) conditionals.
s/CONGIF/CONFIG/
> > +ccflags-$(CONGIF_DEBUG_GPIO) += -DDEBUG > + s/CONGIF/CONFIG/
Otherwise OK.
Sam
| |