Messages in this thread | | | Date | Sat, 29 Dec 2007 17:09:44 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH 1/1] mxser, remove it |
| |
On 12/29/2007 03:23 AM, Alan Cox wrote: >>> +static int mxvar_baud_table[] = { >>> + 0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, >>> + 4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600 >>> +}; >>> +static unsigned int mxvar_baud_table1[] = { >>> + 0, B50, B75, B110, B134, B150, B200, B300, B600, B1200, B1800, B2400, >>> + B4800, B9600, B19200, B38400, B57600, B115200, B230400, B460800, B921600 >>> +}; >> Constify both, if possible? > > These are not portable - baud rate tables vary for some platforms. No > driver should be touching Bxxx coding itself any more. Use the tty_ > functions to decode and encode baud rates.
Thanks for reviews, I'll post fixes for all the issues as separate patches.
| |