lkml.org 
[lkml]   [2007]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.24-rc6-mm1: some section mismatches on sparc64
    On Sat, Dec 29, 2007 at 12:14:11AM -0800, David Miller wrote:
    > From: Adrian Bunk <bunk@kernel.org>
    > Date: Sat, 29 Dec 2007 01:22:56 +0200
    >
    > > At least the sunserial_console_match() one is an obvious Oops
    > > (EXPORT_SYMBOL of an __init function).
    > >
    > > The comment in the description of
    > > commit 58d784a5c754cd66ecd4791222162504d3c16c74 the warning was bogus
    > > is bullshit.
    > >
    > > I'm not sure whether this might count as a 2.6.24-rc regression or
    > > whether 2.6.23 is simply differently but similarly broken (does anyone
    > > actually use the Sun console drivers modular?).
    >
    > You can't do that, the FOO_CONSOLE config options depend upon
    > FOO=y.

    Looking closer, the problem aren't the FOO_CONSOLE options themselves,
    the problem is that with FOO_CONSOLE=n sunserial_console_match() still
    gets called.

    > That's why I'm not worried about this issue and it's not critical at
    > all.

    If a module calls sunserial_console_match() that's an Oops.

    I removed the EXPORT_SYMBOL(sunserial_console_match), and this is the
    result:
    MODPOST 136 modules
    ERROR: "sunserial_console_match" [drivers/serial/sunzilog.ko] undefined!
    ERROR: "sunserial_console_match" [drivers/serial/sunsu.ko] undefined!
    ERROR: "sunserial_console_match" [drivers/serial/sunsab.ko] undefined!

    -ENOHARDWARE, but looking at the code you could call me _very_ surprised
    if you manage to load a modular sunsab from 2.6.24-rc6 on a machine with
    the hardware without getting an Oops.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2007-12-29 09:53    [W:0.023 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site