lkml.org 
[lkml]   [2007]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/30] Unionfs: release special files on copyup
    Date
    If we copyup a special file (char, block, etc.), then dput the source
    object.

    Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
    ---
    fs/unionfs/copyup.c | 7 +++----
    1 files changed, 3 insertions(+), 4 deletions(-)

    diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c
    index 3fe4865..f48209f 100644
    --- a/fs/unionfs/copyup.c
    +++ b/fs/unionfs/copyup.c
    @@ -505,13 +505,12 @@ out_unlock:

    out_free:
    /*
    - * If old_lower_dentry was a directory, we need to dput it. If it
    - * was a file, then it was already dput indirectly by other
    + * If old_lower_dentry was not a file, then we need to dput it. If
    + * it was a file, then it was already dput indirectly by other
    * functions we call above which operate on regular files.
    */
    if (old_lower_dentry && old_lower_dentry->d_inode &&
    - (S_ISDIR(old_lower_dentry->d_inode->i_mode) ||
    - S_ISLNK(old_lower_dentry->d_inode->i_mode)))
    + !S_ISREG(old_lower_dentry->d_inode->i_mode))
    dput(old_lower_dentry);
    kfree(symbuf);

    --
    1.5.2.2


    \
     
     \ /
      Last update: 2007-12-28 21:53    [W:0.022 / U:237.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site