lkml.org 
[lkml]   [2007]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectBuild breakage on powerpc with 2.6.24-rc6-mm1
    Hi,

    I see the following error with the iseries_veth driver in 2.6.24-rc6-mm1

    drivers/net/iseries_veth.c: In function ‘veth_init_connection’:
    drivers/net/iseries_veth.c:818: warning: unused variable ‘rc’
    drivers/net/iseries_veth.c: In function ‘veth_probe_one’:
    drivers/net/iseries_veth.c:1086: error: ‘veth_port_ktypeq’ undeclared
    (first use in this function)
    drivers/net/iseries_veth.c:1086: error: (Each undeclared identifier is
    reported only once
    drivers/net/iseries_veth.c:1086: error: for each function it appears
    in.)
    make[2]: *** [drivers/net/iseries_veth.o] Error 1
    make[1]: *** [drivers/net] Error 2
    make: *** [drivers] Error 2

    Here's a patch, compile tested to fix the compilation problem


    Remove unused variable rc and fix a typo, veth_port_type was called
    veth_port_typeq

    Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
    ---

    drivers/net/iseries_veth.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff -puN drivers/net/iseries_veth.c~fix-iseries-veth-driver drivers/net/iseries_veth.c
    --- linux-2.6.24-rc6/drivers/net/iseries_veth.c~fix-iseries-veth-driver 2007-12-24 03:59:35.000000000 +0530
    +++ linux-2.6.24-rc6-balbir/drivers/net/iseries_veth.c 2007-12-24 04:02:31.000000000 +0530
    @@ -815,7 +815,7 @@ static int veth_init_connection(u8 rlp)
    {
    struct veth_lpar_connection *cnx;
    struct veth_msg *msgs;
    - int i, rc;
    + int i;

    if ( (rlp == this_lp)
    || ! HvLpConfig_doLpsCommunicateOnVirtualLan(this_lp, rlp) )
    @@ -1083,7 +1083,7 @@ static struct net_device * __init veth_p
    return NULL;
    }

    - kobject_init(&port->kobject, &veth_port_ktypeq);
    + kobject_init(&port->kobject, &veth_port_ktype);
    if (0 != kobject_add(&port->kobject, &dev->dev.kobj, "veth_port"))
    veth_error("Failed adding port for %s to sysfs.\n", dev->name);

    _
    --
    Warm Regards,
    Balbir Singh
    Linux Technology Center
    IBM, ISTL
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-12-24 00:03    [W:0.053 / U:29.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site