lkml.org 
[lkml]   [2007]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH - SH/Dreamcast] Add support for GD-Rom device
    On Fri, Dec 21 2007, Jens Axboe wrote:
    > static void gdrom_readdisk_dma(struct work_struct *work)
    > {
    > ...
    >
    > read_command = kzalloc(sizeof(struct packet_command), GFP_KERNEL);
    > if (!read_command)
    > probably just defer the work to some time later
    >
    > spin_lock(&gdrom_lock);
    > while (!list_empty(&gdrom_deferred)) {
    > req = list_entry(gdrom_deferred.next, struct request, queuelist);
    > list_del_init(&req->queuelist);
    > spin_unlock(&gdrom_lock);
    >
    > ...
    >
    > spin_lock(&gdrom_lock);
    > };
    >
    + spin_unlock(&gdrom_lock);
    > kfree(read_command);
    > }

    is missing, of course.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2007-12-21 13:29    [W:4.176 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site