lkml.org 
[lkml]   [2007]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] SC26XX: New serial driver for SC2681 uarts
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
> > +#define READ_SC(p, r) readb ((p)->membase + RD_##r)
> > +#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)
>
> No space before the (. checkpatch misses this.

Yep, over careful in the special case for the parameters for #define
macros, which have different spacing rules. This will be fixed in 0.13:

WARNING: no space between function name and open parenthesis '('
#1: FILE: Z45.c:1:
+#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)

-apw


\
 
 \ /
  Last update: 2007-12-21 18:39    [from the cache]
©2003-2011 Jasper Spaans