Messages in this thread | | | Subject | Re: [PATCH 1/2] DMA buffer alignment annotations | From | Roland Dreier <> | Date | Fri, 21 Dec 2007 08:58:50 -0800 |
| |
> > +#define __dma_aligned __attribute__((aligned(ARCH_MIN_DMA_ALIGNMENT))) > > +#define __dma_buffer __dma_buffer_line(__LINE__) > > +#define __dma_buffer_line(line) __dma_aligned;\ > > + char __dma_pad_##line[0] __dma_aligned
> You introduce __dma_buffer_line() if ARCH_MIN_DMA_ALIGNMENT is set but > not if it isn't...
__dma_buffer_line() is just an internal implementation detail to take care of string pasting properly. Perhaps there should be a comment warning people not to use it directly.
- R.
| |