Messages in this thread | | | Date | Fri, 21 Dec 2007 15:22:22 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device |
| |
On Fri, Dec 21 2007, Adrian McMenamin wrote: > On 21/12/2007, Jens Axboe <jens.axboe@oracle.com> wrote: > > > > Your design is also heavily geared towards there just being a single > > CDROM, I'm assuming this wont be a problem given your hw (it sets a bad > > example for others to follow though, lots of violations against normal > > programming practice for multiple devices and smp). > > > Yes, because is there only one device and there will only ever be one > device (unless you know of somebody doing Dreamcast hardware > development). > > I understand the point you are making but adding in additional code > would only diminish resource availability or slow performance on a > small machine without actually delivering any better outcomes for > kernel users.. > > Is it reaslly necessary?
No it's not necessary, it was just a general reflection on how it could have been done more in style with "regular" drivers.
-- Jens Axboe
| |