lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Update ip command line processing
On Thu, Dec 20, 2007 at 03:21:21PM -0800, David Miller wrote:
> From: Simon Horman <horms@verge.net.au>
> Date: Tue, 18 Dec 2007 17:57:32 +0900
>
> > @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config);
> > */
> > static int __init ic_proto_name(char *name)
> > {
> > + if (!name) {
> > + return 1;
> > + }
>
> I do not see any circumstance under which this pointer can
> be NULL. Judging by your other changes, I think you mean
> to use "!*name" here.
>
> Maybe:
>
> if (*name == '\0')
>
> would make it clearer what you're checking for, an
> empty string.
>
> Otherwise I'm fine with your change.

Sorry, I meant if (*name == '\0') as you suggest to replace the first
portion of:

- ic_enable = (*addrs &&
- (strcmp(addrs, "off") != 0) &&
- (strcmp(addrs, "none") != 0));

I'll send an updated patch shortly.

--
Horms



\
 
 \ /
  Last update: 2007-12-21 02:35    [W:0.036 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site