lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] msi: set 'En' bit of MSI Mapping Capability
Date
Andrew Morton <akpm@linux-foundation.org> writes:

> On Wed, 19 Dec 2007 16:41:25 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> It would be better to just add a stub implementation of
>> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
>> tricks.
>
>
> And by this I really do mean going into each include/asm-*/pci.h and adding
>
>
> struct pci_dev; (if needed)
> ...
>
> static inline void ht_enable_msi_mapping(struct pci_dev *dev)
> {
> }
>
>
> no macros, no ifdef tricks, no include tricks. Just straight, clean, fully
> typechecked C.

Andrew thanks for the code style review. I goofed about recommending the
ARCH_HAVE_XXXX thing.

I'm going to concentrate on the content for the moment. I think we
are very close to a general solution to a very common problem with
MSI interrupts.

Eric


\
 
 \ /
  Last update: 2007-12-20 23:57    [W:0.277 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site