lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Trailing periods in kernel messages
On Thu, 20 Dec 2007 21:54:11 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> > Documentation/Coding Style
> >
> > Chapter 13: Printing kernel messages
> >
> > Kernel messages do not have to be terminated with a period.
>
>
> This piece of the document is wrong. It should also be changed. I've no
> idea how such a ludicrous statement ever got into the Coding Style but I
> have never seen it discussed and an archive search suggests it just
> sneaked in without any kind of approval and discussion the list.
>
> Kernel messages are in English. Let us keep it that way. Missing
> punctuation is equated by many parts of the English speaking world with
> poor quality, sloppy products and low levels of education. These are not
> things with which we wish to be associated IMHO.
>
> NAK to the patch.

akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' . | wc -l
105297
akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' . | wc -l
12743

For the record, I won't be taking any "add period to printk" patches.

akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' net | wc -l
4978
akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' net | wc -l
493

Send 'em to Dave!


\
 
 \ /
  Last update: 2007-12-20 23:29    [W:0.121 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site