Messages in this thread |  | | Date | Wed, 19 Dec 2007 13:15:39 +0300 | | From | "Alexey Dobriyan" <> | | Subject | Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning |
| |
On 12/19/07, David Chinner <dgc@sgi.com> wrote:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7cd94146cd504016315608e297219f9fb7b1413b > > included security.h in mm.h and that is how I'm seeing the namespace > poisoning coming from key.h when !CONFIG_KEY. > > Including security.h in mm.h means much wider includes for pretty > much the entire kernel, and it opens up namespace issues like this > that never previously existed.
ACK, removing sched.h from mm.h was quite painful and security.h added it back unconditionally. As result, standalone mm.h inclusion goes from ~9K to ~16K of code after preprocessing which is quite unpleasant.
> --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -12,7 +12,6 @@ > #include <linux/prio_tree.h> > #include <linux/debug_locks.h> > #include <linux/mm_types.h> > -#include <linux/security.h>
|  |