[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces

    On Tue, 2007-12-18 at 12:37 +0300, Ivan Kokshaysky wrote:
    > On Tue, Dec 18, 2007 at 11:02:37AM +1100, Benjamin Herrenschmidt wrote:
    > > +EXPORT_SYMBOL(pci_enable_device_io);
    > > +EXPORT_SYMBOL(pci_enable_device_mem);
    > > EXPORT_SYMBOL(pci_enable_device);
    > Wouldn't it be better to export only the pci_enable_device_flags()
    > and make these three just "static inline" wrappers in pci.h?

    Been thinking about it yeah. I don't want drivers to start using
    the _flags version directly tho, which is why I preferred going that
    way but if people prefer the inline version, I'll do that.

    > > EXPORT_SYMBOL(pcim_enable_device);
    > Looks like many SATA drivers would benefit from pcim_* equivalents
    > of pci_enable_device_{io,mem}, as they could happily work with just
    > a single MMIO BAR... Alan?

    I have no experience with the pcim stuff, I would appreciate if somebody
    took care of that part.


     \ /
      Last update: 2007-12-18 10:47    [W:0.040 / U:8.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site