Messages in this thread | | | Date | Tue, 18 Dec 2007 18:09:43 -0500 | From | Erez Zadok <> | Subject | Re: [PATCH 3/4] unionfs: restructure unionfs_setattr |
| |
In message <Pine.LNX.4.64.0712182213300.28390@blonde.wat.veritas.com>, Hugh Dickins writes: > In order to fix unionfs truncation, we need to move the lower notify_change > out of the loop in unionfs_setattr. But when I came to do that, I couldn't [...]
Hugh, I want to understand how patches 3/4 and 4/4 are related. In patch 3 you say "in order to fix truncation" but you mention a truncation problem only in patch 4; is there a patch ordering problem, or they're both related to the same issue (with 3/4 being a code cleanup, and 4/4 actually fixing the problem)?
What tests did you conduct to tickle this truncation problem: I assume fsx-linux through unionfs, mounted on tmpfs? Did that include both series of patches (your 9 tmpfs patches, plus the two memcgrpoup?).
Thanks, Erez.
| |