[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC/PATCH 2/8] revoke: inode revoke lock V7
    This is a relatively minor detail in the rather bigger context of this
    patch, but...

    > @@ -642,6 +644,7 @@ struct inode {
    > struct list_head inotify_watches; /* watches on this inode */
    > struct mutex inotify_mutex; /* protects the watches list */
    > #endif
    > + wait_queue_head_t i_revoke_wait;

    That seems like a relatively hefty addition to every inode in the system
    when revoke - I think - will be a fairly rare operation. Would there be
    any significant cost to using a single, global revoke-wait queue instead
    of growing the inode structure?


     \ /
      Last update: 2007-12-18 17:41    [W:0.019 / U:18.032 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site