Messages in this thread | | | Date | Tue, 18 Dec 2007 14:32:21 +0100 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH v2] atmel_serial: Clean up the code |
| |
On Tue, 18 Dec 2007 21:22:01 +0800 steve birtles <arm_kernel_development@micromark.net.cn> wrote:
> Is there any change can we clean this up? > /* > * We wrap our port structure around the generic uart_port. > @@ -142,8 +146,8 @@ static void atmel_set_mctrl(struct uart_port > *port, u_int mctrl) > #ifdef CONFIG_ARCH_AT91RM9200 > if (cpu_is_at91rm9200()) { > /* > - * AT91RM9200 Errata #39: RTS0 is not internally connected to PA21. > - * We need to drive the pin manually. > + * AT91RM9200 Errata #39: RTS0 is not internally connected > + * to PA21. We need to drive the pin manually. > */ > if (port->mapbase == AT91RM9200_BASE_US0) { > if (mctrl & TIOCM_RTS) > @@ -228,7 +232,8 @@ static void atmel_stop_rx(struct uart_port *port) > */
I'm not sure what you mean. It just breaks the comment to fit within 80 columns...
> and potentially add those flags for dealing with the CTS & RTS , > that may not be used on every board, because this clean up sit's in > my minor changes for the YL9200, specifically to re-jig the USARTS > lines so that we can separate RXD TXD , from a forced requirment to > use control lines when using 232
Could you just post your changes so that we can see where it fits in?
Haavard
| |