lkml.org 
[lkml]   [2007]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0
    From
    On Tue, Dec 18, 2007 at 04:24:04AM -0800, Andrew Morton wrote:
    > On Tue, 18 Dec 2007 13:03:00 +0100 (CET) Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
    > > --- a/mm/page_alloc.c
    > > +++ b/mm/page_alloc.c
    > > @@ -3427,7 +3427,7 @@ static void __init_refok alloc_node_mem_map(struct pglist_data *pgdat)
    > > mem_map = NODE_DATA(0)->node_mem_map;
    > > #ifdef CONFIG_ARCH_POPULATES_NODE_MAP
    > > if (page_to_pfn(mem_map) != pgdat->node_start_pfn)
    > > - mem_map -= pgdat->node_start_pfn;
    > > + mem_map -= (pgdat->node_start_pfn - ARCH_PFN_OFFSET);
    > > #endif /* CONFIG_ARCH_POPULATES_NODE_MAP */
    > > }
    > > #endif
    >
    > hm. It's rather non-trivial to verify that this will compile OK on all
    > architectures.

    I grepped through include/asm-* and found:

    #if defined(CONFIG_FLATMEM)

    #ifndef ARCH_PFN_OFFSET
    #define ARCH_PFN_OFFSET (0UL)
    #endif

    in include/asm-generic/memory_model.h. So I'm still confident, that
    this works on all architectures. It's tested on MIPS.

    Thomas.

    --
    Crap can work. Given enough thrust pigs will fly, but it's not necessary a
    good idea. [ RFC1925, 2.3 ]


    \
     
     \ /
      Last update: 2007-12-18 17:13    [W:0.021 / U:239.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site